feat(runner): add resolveAsCell() method to Cell API
#1916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds a new Cell API method resolveAsCell() to resolve a cell reference to the actual underlying cell, along with tests demonstrating its use.
- Introduces resolveAsCell() on Cell and RegularCell implementations.
- Updates public API typings to include resolveAsCell().
- Adds a unit test validating resolution of a nested cell reference.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/runner/src/cell.ts | Implements resolveAsCell() and updates JSDoc. |
| packages/api/index.ts | Exposes resolveAsCell() on the public Cell interface. |
| packages/runner/test/cell.test.ts | Adds test for resolving a nested cell reference. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Adds a new `resolveAsCell()` method that resolves a cell reference to the actual cell it points to. This is useful when accessing data via .key() and wanting a direct reference to the final underlying document, e.g. to create an id for it. The method is equivalent to wrapping the current schema in `Cell<>` and calling `.get()`, providing a more convenient API for this common pattern. Includes test coverage for resolving nested cell references.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
a1234d4 to
e5fca47
Compare
ubik2
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
resolveAsCell()method that resolves a cell reference to the actual cell it points to. This is useful when accessing data via .key() and wanting a direct reference to the final underlying document, e.g. to create an id for it.The method is equivalent to wrapping the current schema in
Cell<>and calling.get(), providing a more convenient API for this common pattern.Includes test coverage for resolving nested cell references.
Summary by cubic
Added resolveAsCell() to the Cell API to resolve a linked cell to the actual target cell. Helpful after .key() to get a direct cell for the final document.