Create ct, recipe-dev and lit-component Claude skills
#1933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
4 issues found across 23 files
Prompt for AI agents (all 4 issues)
Understand the root cause of the following 4 issues and fix them.
<file name=".claude/skills/lit-component/references/advanced-patterns.md">
<violation number="1" location=".claude/skills/lit-component/references/advanced-patterns.md:41">
Declare the `#unsubs` private field before using it in the `CTThemeProvider` example so the code compiles and matches the cleanup pattern described.</violation>
</file>
<file name=".claude/skills/ct/SKILL.md">
<violation number="1" location=".claude/skills/ct/SKILL.md:1">
This pull request removes the `.claude/commands/` directory but fails to update multiple files that still reference the old commands. Files like `.claude/agents/research-specialist.md`, `AGENTS.md`, and the root `README.md` contain hardcoded paths and instructions pointing to the deleted command files. This will lead to broken links and non-functional agent workflows.</violation>
</file>
<file name=".claude/skills/lit-component/references/component-patterns.md">
<violation number="1" location=".claude/skills/lit-component/references/component-patterns.md:38">
Hard-coding the computed class entries to true forces classes like `gap-undefined` when optional props are unset; gate each class with the corresponding property before using classMap.</violation>
<violation number="2" location=".claude/skills/lit-component/references/component-patterns.md:199">
Registering the element unconditionally with `customElements.define` will throw on module re-evaluation (e.g., during HMR or repeated tests); guard the registration before defining the element.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
|
|
||
| #setupSubscriptions() { | ||
| // Clean up previous subscriptions | ||
| for (const off of this.#unsubs) off(); |
There was a problem hiding this comment.
Declare the #unsubs private field before using it in the CTThemeProvider example so the code compiles and matches the cleanup pattern described.
Prompt for AI agents
Address the following comment on .claude/skills/lit-component/references/advanced-patterns.md at line 41:
<comment>Declare the `#unsubs` private field before using it in the `CTThemeProvider` example so the code compiles and matches the cleanup pattern described.</comment>
<file context>
@@ -0,0 +1,453 @@
+
+ #setupSubscriptions() {
+ // Clean up previous subscriptions
+ for (const off of this.#unsubs) off();
+ this.#unsubs = [];
+
</file context>
| @@ -0,0 +1,375 @@ | |||
| --- | |||
There was a problem hiding this comment.
This pull request removes the .claude/commands/ directory but fails to update multiple files that still reference the old commands. Files like .claude/agents/research-specialist.md, AGENTS.md, and the root README.md contain hardcoded paths and instructions pointing to the deleted command files. This will lead to broken links and non-functional agent workflows.
Prompt for AI agents
Address the following comment on .claude/skills/ct/SKILL.md at line 1:
<comment>This pull request removes the `.claude/commands/` directory but fails to update multiple files that still reference the old commands. Files like `.claude/agents/research-specialist.md`, `AGENTS.md`, and the root `README.md` contain hardcoded paths and instructions pointing to the deleted command files. This will lead to broken links and non-functional agent workflows.</comment>
<file context>
@@ -0,0 +1,375 @@
+---
+name: ct
+description: Guide for using the ct (CommonTools) binary to interact with charms, recipes, and the Common Fabric. Use this skill when deploying recipes, managing charms, linking data between charms, or debugging recipe execution. Triggers include requests to "deploy this recipe", "call a handler", "link these charms", "get data from charm", or "test this recipe locally".
</file context>
| } | ||
| } | ||
|
|
||
| globalThis.customElements.define("ct-button", CTButton); |
There was a problem hiding this comment.
Registering the element unconditionally with customElements.define will throw on module re-evaluation (e.g., during HMR or repeated tests); guard the registration before defining the element.
Prompt for AI agents
Address the following comment on .claude/skills/lit-component/references/component-patterns.md at line 199:
<comment>Registering the element unconditionally with `customElements.define` will throw on module re-evaluation (e.g., during HMR or repeated tests); guard the registration before defining the element.</comment>
<file context>
@@ -0,0 +1,480 @@
+ }
+}
+
+globalThis.customElements.define("ct-button", CTButton);
+```
+
</file context>
Suggested change
| globalThis.customElements.define("ct-button", CTButton); | |
| globalThis.customElements.get("ct-button") ?? globalThis.customElements.define("ct-button", CTButton); |
| override render() { | ||
| const classes = { | ||
| stack: true, | ||
| [`gap-${this.gap}`]: true, |
There was a problem hiding this comment.
Hard-coding the computed class entries to true forces classes like gap-undefined when optional props are unset; gate each class with the corresponding property before using classMap.
Prompt for AI agents
Address the following comment on .claude/skills/lit-component/references/component-patterns.md at line 38:
<comment>Hard-coding the computed class entries to true forces classes like `gap-undefined` when optional props are unset; gate each class with the corresponding property before using classMap.</comment>
<file context>
@@ -0,0 +1,480 @@
+ override render() {
+ const classes = {
+ stack: true,
+ [`gap-${this.gap}`]: true,
+ [`align-${this.align}`]: true,
+ [`justify-${this.justify}`]: true,
</file context>
Suggested change
| [`gap-${this.gap}`]: true, | |
| [`gap-${this.gap}`]: !!this.gap, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ct,lit-componentandrecipe-devskillsSummary by cubic
Replaced the old command-based Claude prompts with three focused skills—ct, recipe-dev, and lit-component—to provide clearer, task-based guidance for CLI usage, recipe development, and UI components. This improves discoverability, consistency, and day-to-day developer workflows.
New Features
Migration