Skip to content

fix(api): fn in OpaqueRef.map(fn) gets OpaqueRef arguments #1937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2025
Merged

fix(api): fn in OpaqueRef.map(fn) gets OpaqueRef arguments #1937

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/api/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,11 @@ export interface OpaqueRefMethods<T> {
setSchema(schema: JSONSchema): void;
map<S>(
fn: (
element: T extends Array<infer U> ? Opaque<U> : Opaque<T>,
index: Opaque<number>,
array: T,
element: T extends Array<infer U> ? OpaqueRef<U> : OpaqueRef<T>,
index: OpaqueRef<number>,
array: OpaqueRef<T>,
) => Opaque<S>,
): Opaque<S[]>;
): OpaqueRef<S[]>;
}

// Factory types
Expand Down
4 changes: 2 additions & 2 deletions packages/runner/src/builder/opaque-ref.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,8 @@ export function opaqueRef<T>(
},
map: <S>(
fn: (
element: Opaque<Required<T extends Array<infer U> ? U : T>>,
index: Opaque<number>,
element: OpaqueRef<Required<T extends Array<infer U> ? U : T>>,
index: OpaqueRef<number>,
array: T,
) => Opaque<S>,
) => {
Expand Down
8 changes: 4 additions & 4 deletions packages/runner/src/builder/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,11 +123,11 @@ declare module "@commontools/api" {
unsafe_getExternal(): OpaqueRef<T>;
map<S>(
fn: (
element: T extends Array<infer U> ? Opaque<U> : Opaque<T>,
index: Opaque<number>,
array: T,
element: T extends Array<infer U> ? OpaqueRef<U> : OpaqueRef<T>,
index: OpaqueRef<number>,
array: OpaqueRef<T>,
) => Opaque<S>,
): Opaque<S[]>;
): OpaqueRef<S[]>;
toJSON(): unknown;
[Symbol.iterator](): Iterator<T>;
[Symbol.toPrimitive](hint: string): T;
Expand Down
2 changes: 1 addition & 1 deletion packages/static/assets/types/commontools.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export interface OpaqueRefMethods<T> {
setDefault(value: Opaque<T> | T): void;
setName(name: string): void;
setSchema(schema: JSONSchema): void;
map<S>(fn: (element: T extends Array<infer U> ? Opaque<U> : Opaque<T>, index: Opaque<number>, array: T) => Opaque<S>): Opaque<S[]>;
map<S>(fn: (element: T extends Array<infer U> ? OpaqueRef<U> : OpaqueRef<T>, index: OpaqueRef<number>, array: OpaqueRef<T>) => Opaque<S>): OpaqueRef<S[]>;
}
export interface Recipe {
argumentSchema: JSONSchema;
Expand Down