Updated documentation with Claude's learnings after struggling to bui… #1943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ld a specific type of pattern.
seefeldb
requested changes
Oct 22, 2025
There was a problem hiding this comment.
The underlying issue here is missing closure support for derives:
l.77: <ct-button onClick={applyData({ data: extractionResult })}>
it used extractionResult here instead of result, otherwise this would have worked.
it's overall better to not create UI inside derive (inside map is fine and actually common), so that's maybe what we should add to the docs. but the changes claude proposed here are otherwise misleading.
|
Got it, I'll close this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ld a specific type of pattern, profile.tsx in the recipes repo.
Not sure if what Claude learned is actually helpful changes to the documentation or not.
Summary by cubic
Clarifies handler binding rules in HANDLERS.md to prevent ReadOnlyAddressError when binding inside derive(), and adds troubleshooting tips for common handler issues to help recipe authors avoid mistakes.