Fix charm list view auto-dismiss #1945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We regressed when reworking the 'active charm' concept. Clicking the 🔍 should show the charms list, clicking an item should navigate to it and dismiss the list. After our recent changes, we no longer automatically dismissed the list. This PR corrects that behaviour.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We regressed when reworking the 'active charm' concept. Clicking the 🔍 should show the charms list, clicking an item should navigate to it and dismiss the list. After our recent changes, we no longer automatically dismissed the list. This PR corrects that behaviour.
Summary by cubic
Restores auto-dismiss for the charm list: selecting a charm from the 🔍 list now activates it and hides the list. Fixes regression from the active charm rework.