-
Notifications
You must be signed in to change notification settings - Fork 9
spec(runner): updated plan for DX1 & adjusted specs #1950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 issues found across 7 files
Prompt for AI agents (all 2 issues)
Understand the root cause of the following 2 issues and fix them.
<file name="docs/specs/recipe-construction/rollout-plan.md">
<violation number="1" location="docs/specs/recipe-construction/rollout-plan.md:65">
The plan item misspells the intended helper as `Cell.for(casue)`, which will confuse readers about the correct API name and parameter order.</violation>
</file>
<file name="docs/specs/recipe-construction/graph-snapshot.md">
<violation number="1" location="docs/specs/recipe-construction/graph-snapshot.md:116">
This rewording conflicts with the earlier Snapshot Envelope section, which still directs persisting the snapshot under the `graph` metadata key; please reconcile the document to name a single field.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
631518f to
756f1d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Updated the DX1 plan to use TypeScript branded types for capabilities and switch to an in-place migration that unifies the Cell API. Graph snapshots move to Phase 2, and the pattern integration test harness is complete; the V2 opt-in plan is removed.
Refactors
CellLikeplusOpaqueRef,Cell,ReadonlyCell,WriteonlyCell, andStream. OpaqueRef keeps proxy behavior..for(cause, flexible?)with clear throw rules.processmetadata.implementation-plan-v2.md.Migration
.for(), track causes, and writeprocessmetadata..for(variableName, true)and update schemas.OpaqueRefand.setDefault. Future work: ship serializable node factories (nodeFactory@1,.curry).