-
Notifications
You must be signed in to change notification settings - Fork 9
smoketest version of ralph, basic files #1951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c45a41a to
497d3fa
Compare
497d3fa to
011800e
Compare
93b7e0c to
f0b0255
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 issues found across 6 files
Prompt for AI agents (all 2 issues)
Understand the root cause of the following 2 issues and fix them.
<file name="tools/ralph/Dockerfile">
<violation number="1" location="tools/ralph/Dockerfile:88">
`sleep infinity` keeps the container alive even after the smoketest finishes (and masks its exit status). The smoketest can’t signal failure or allow the container to exit. Remove the trailing `sleep infinity` so the shell exits with the smoketest result.</violation>
</file>
<file name="tools/ralph/TASKS.md">
<violation number="1" location="tools/ralph/TASKS.md:3">
This line introduces a Markdown bullet with no content, which renders as a blank bullet before each task. Remove the stray '-' or merge it with the task entry to keep the checklist readable.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
|
i think this is good for the first batch to enable smoke testing. [ ] i set up mcp playwright in Dockerfile but then we rewrite the setup with the bindmounts, need to fix this Cleanup: |
Summary by cubic
Add a smoketest mode for Ralph that runs servers, executes a guided prompt, and then exits. Dockerfile now runs the smoketest by default, and new files guide task execution and capture results.
New Features
Migration