fix(transformation): Capture outer-scope variables in shorthand property assignments

[seefeldb]

Fixes bug where variables in shorthand assignments inside map callbacks weren't captured. Filters ShorthandPropertyAssignment from declarations and checks if identifiers match callback parameters.

---

Summary by cubic

Fixes incorrect capturing in map callbacks when using object shorthand, and prevents synthetic callback params from leaking into outer derives. This resolves runtime errors and aligns closure behavior with expected JSX map patterns.

• Bug Fixes
  • Capture outer variables in shorthand property assignments inside map callbacks by treating ShorthandPropertyAssignment as non-declarations and checking callback parameters. Addresses CT-1004 where destructured recipe params weren’t moved into the closed-over scope.
  • Filter synthetic identifiers (no symbol) in outer-scope derive analysis. Keep synthetic params when inside a map-callback scope; drop them only at outer scope with multiple real captures. Prevents ReferenceError in nested map within conditionals.

[linear]

CT-1004 destructured recipe param isn't moved into closed over variables

[cubic-dev-ai]

1 issue found across 6 files

Prompt for AI agents (all 1 issues)

Understand the root cause of the following 1 issues and fix them.


<file name="packages/ts-transformers/src/closures/transformer.ts">

<violation number="1" location="packages/ts-transformers/src/closures/transformer.ts:187">
Array-destructured map parameters (e.g. `([item]) =&gt; ({ item })`) also trigger the `realDeclarations.length === 0` path, but this branch never recognizes ArrayBindingPattern names, so `item` is mis-classified as an outer capture and the transform emits `params: { item }` with `item` undefined at runtime. Please treat array patterns the same way as object ones here.</violation>
</file>

_{React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.}