feat: Migrate @commontools/html into a jsx-runtime implementation. #1958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6e6db39 to
6728861
Compare
* @commontools/html is now a valid jsx-runtime implementation, like
preact
* @commontools/html is set as the Deno workspace jsx runtime
* The pattern runtime still uses a global `h` render function that can
be aligned in the future.
* Removed react/react-dom/@types providing the React jsx runtime
* Hack to support serving `iframe-bootstrap.js`, which has runtime deps
not in our workspace, by renaming the file extension to work around
this upstream issue: denoland/deno#27505
* Removes @babel/standalone, and enables the full removal of React
deps
There was a problem hiding this comment.
1 issue found across 11 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="packages/html/src/jsx-runtime.ts">
<violation number="1" location="packages/html/src/jsx-runtime.ts:47">
The JSX runtime ignores the `_key` argument, so keyed JSX elements lose their keys when compiled with `jsx: "react-jsx"`. Without the key, list reconciliation and any component logic that depends on it will misbehave. Please merge `_key` back into the props before calling `h`.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
| ? children | ||
| : [children]; | ||
|
|
||
| return h(type, restProps, ...childArray); |
There was a problem hiding this comment.
The JSX runtime ignores the _key argument, so keyed JSX elements lose their keys when compiled with jsx: "react-jsx". Without the key, list reconciliation and any component logic that depends on it will misbehave. Please merge _key back into the props before calling h.
Prompt for AI agents
Address the following comment on packages/html/src/jsx-runtime.ts at line 47:
<comment>The JSX runtime ignores the `_key` argument, so keyed JSX elements lose their keys when compiled with `jsx: "react-jsx"`. Without the key, list reconciliation and any component logic that depends on it will misbehave. Please merge `_key` back into the props before calling `h`.</comment>
<file context>
@@ -0,0 +1,72 @@
+ ? children
+ : [children];
+
+ return h(type, restProps, ...childArray);
+}
+
</file context>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hrender function that can be aligned in the future.iframe-bootstrap.js, which has runtime deps not in our workspace, by renaming the file extension to work around this upstream issue:deno compileshould not surface graph errors for modules specified on--includedenoland/deno#27505Summary by cubic
Migrated the workspace to use @commontools/html as a drop-in JSX runtime, replacing React and simplifying our build. This adds jsx-runtime/jsx-dev-runtime support and removes React/Babel dependencies.
New Features
Dependencies