fix(html): treat false as null/undefined in render (skip rendering) #1963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, false values in children would render as the text 'false'. Now false is treated the same as null and undefined - it renders as an empty text element (nothing visible). This aligns with common JSX/React behavior where boolean false is used for conditional rendering and should not produce output. - Updated render.ts to check for false in addition to null/undefined - Added test case verifying false, null, undefined render as empty - Updated html-recipes test to use str template for explicit string conversion 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Author
|
this is because of all the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, false values in children would render as the text 'false'. Now false is treated the same as null and undefined - it renders as an empty text element (nothing visible).
This aligns with common JSX/React behavior where boolean false is used for conditional rendering and should not produce output.
🤖 Generated with Claude Code
Summary by cubic
Treat boolean false like null/undefined during HTML rendering, so it doesn’t produce visible text. This prevents stray “false” in the DOM and matches JSX/React conditional rendering.