refactor(cli): make charm execution explicit via required runIt parameter

[seefeldb]

Summary

Previously, CharmManager.get() defaulted to running charms (runIt=true), causing unnecessary charm execution for read/write operations. This PR changes the default to false and ensures all callers explicitly pass the runIt parameter.

Changes

• Changed default runIt from true to false in:

  • CharmManager.get() (packages/charm/src/manager.ts)
  • CharmsController.get() (packages/charm/src/ops/charms-controller.ts)

• Updated CLI lib functions to explicitly pass runIt:

  • Pass false for read/write operations: inspect, get, set, apply, getsrc, setsrc
  • Pass true for operations requiring execution: call, render

• Updated shell AppView to pass runIt: true when displaying active charm

Benefits

✅ Eliminates unnecessary charm runs for commands like ct charm ls, inspect, get, set, etc.
✅ Makes code intent explicit at every call site
✅ Improves performance by avoiding unnecessary work
✅ Maintains correct behavior for commands that need execution (call, render, step)

Commands That No Longer Run Charms

• ct charm ls - List charms
• ct charm inspect - Inspect charm data
• ct charm view - Display view
• ct charm get - Get cell value
• ct charm set - Set cell value
• ct charm apply - Apply input
• ct charm getsrc - Get source
• ct charm setsrc - Set source
• ct charm rm - Remove charm
• ct charm link - Link charms
• ct charm map - Display map

Commands That Still Run Charms (As Intended)

• ct charm call - Executes handler (needs charm running)
• ct charm render - Renders UI (needs latest state)
• ct charm step - Explicitly runs one step
• ct charm new --start - Optionally starts new charm
• ct dev - Local testing environment

Technical Notes

TypeScript Type Complexity

Initial attempt to make runIt a required parameter (no default) caused TypeScript OOM during type checking. The issue was removing the middle overload signature with optional runIt?.

Solution: Preserved all three overload signatures to avoid type explosion, only changed the default value in the implementation.

Testing

• ✅ All CLI tests pass
• ✅ Type checker completes without OOM
• ✅ Verified on both main and branch

Test Plan

• Run deno test in packages/cli
• Verify type checking doesn't OOM
• Test ct charm commands manually (if desired)

🤖 Generated with Claude Code

---

Summary by cubic

Make charm execution opt-in by requiring an explicit runIt flag for get(). This avoids unintended runs for read/write operations and improves CLI and shell performance.

• Refactors

  • CharmManager.get default runIt=false.
  • CharmsController.get adds runIt (default false) and forwards it.
  • CLI: pass false for inspect/get/set/apply/getsrc/setsrc; true for call/render.
  • Shell AppView: pass true when loading the active charm.
  • Preserved existing overloads; only changed the default to avoid TypeScript perf issues.

• Migration

  • Update external get() call sites to pass runIt.
  • Use true when execution/state refresh is needed (call, render, step); otherwise false.
  • If you relied on implicit execution before, set runIt=true to keep behavior.

[cubic-dev-ai]

No issues found across 5 files