Skip to content

Ellyse/smoketest mac #1972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 28, 2025
Merged

Ellyse/smoketest mac #1972

merged 9 commits into from
Oct 28, 2025

Conversation

@ellyxir
Copy link
Contributor

@ellyxir ellyxir commented Oct 28, 2025 •
edited by cubic-dev-ai bot
Loading

Summary by cubic

Make run_smoketest.sh work reliably on macOS by pulling Claude credentials from the Keychain and fixing Playwright sandboxing in Docker.

  • Bug Fixes
    • On macOS, read credentials from the Keychain and write them into /tmp/home; keep file copy on Linux.
    • Add Docker flags (SYS_ADMIN, seccomp=unconfined) and pass --disable-setuid-sandbox to the Playwright MCP to avoid permission errors.

@ellyxir ellyxir self-assigned this Oct 28, 2025
@ellyxir ellyxir marked this pull request as ready for review October 28, 2025 18:37
@ellyxir ellyxir requested a review from seefeldb October 28, 2025 18:37
cubic-dev-ai[bot]
cubic-dev-ai bot reviewed Oct 28, 2025
View reviewed changes
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

cubic-dev-ai[bot]
cubic-dev-ai bot reviewed Oct 28, 2025
View reviewed changes
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

cubic-dev-ai[bot]
cubic-dev-ai bot reviewed Oct 28, 2025
View reviewed changes
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

cubic-dev-ai[bot]
cubic-dev-ai bot reviewed Oct 28, 2025
View reviewed changes
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

cubic-dev-ai[bot]
cubic-dev-ai bot reviewed Oct 28, 2025
View reviewed changes
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

@ellyxir ellyxir merged commit 7bb002a into main Oct 28, 2025
9 checks passed
@ellyxir ellyxir deleted the ellyse/smoketest-mac branch October 28, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

@seefeldb seefeldb Awaiting requested review from seefeldb

Assignees

@ellyxir ellyxir

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ellyxir @jakedahn