Skip to content

Summarize completedTx in tool calll response #1985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 30, 2025
Merged

Summarize completedTx in tool calll response #1985

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
982256c
WIP tx-analysis
bfollington Oct 30, 2025
02bb4f6
Add real implementation
bfollington Oct 30, 2025
ac4b53c
Remove test data and scripts
bfollington Oct 30, 2025
4a9c689
Refine tx summary
bfollington Oct 30, 2025
a472ffb
Remove long pointless README
bfollington Oct 30, 2025
6d1223d
Remove accidental `mise.toml`
bfollington Oct 30, 2025
71da3a3
Remove JournalMock from tests
bfollington Oct 30, 2025
4e836a4
Remove unused analysis
bfollington Oct 30, 2025
86d790a
Format and lint
bfollington Oct 30, 2025
b2d47cb
PR feedback
bfollington Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions packages/runner/src/builtins/llm-dialog.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ import { ID, NAME, type Recipe, TYPE } from "../builder/types.ts";
import type { Action } from "../scheduler.ts";
import type { IRuntime } from "../runtime.ts";
import type { IExtendedStorageTransaction } from "../storage/interface.ts";
import {
debugTransactionWrites,
formatTransactionSummary,
} from "../storage/transaction-summary.ts";
import { parseLink } from "../link-utils.ts";
// Avoid importing from @commontools/charm to prevent circular deps in tests

Expand Down Expand Up @@ -811,8 +815,13 @@ async function invokeToolCall(
...toolCall.input,
result, // doesn't HAVE to be used, but can be
}, (completedTx: IExtendedStorageTransaction) => {
resolve(result.withTx(completedTx).get()); // withTx likely superfluous
}); // TODO(bf): why any needed?
logger.info("Handler tx:", debugTransactionWrites(completedTx));

const summary = formatTransactionSummary(completedTx, space);
const value = result.withTx(completedTx).get();

resolve({ value, summary });
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot Oct 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handler tool results are now double-wrapped, so LLM/tool consumers receive { value: { value, summary } } instead of the handler output.

Prompt for AI agents 
Address the following comment on packages/runner/src/builtins/llm-dialog.ts at line 823:

<comment>Handler tool results are now double-wrapped, so LLM/tool consumers receive `{ value: { value, summary } }` instead of the handler output.</comment>

<file context>
@@ -811,8 +815,13 @@ async function invokeToolCall(
+        const summary = formatTransactionSummary(completedTx, space);
+        const value = result.withTx(completedTx).get();
+
+        resolve({ value, summary });
+      });
     } else {
</file context>
Fix with Cubic

});
} else {
throw new Error("Tool has neither pattern nor handler");
}
Expand Down
6 changes: 6 additions & 0 deletions packages/runner/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,12 @@ export type {
IExtendedStorageTransaction,
MemorySpace,
} from "./storage/interface.ts";
export {
debugTransactionWrites,
formatTransactionSummary,
summarizeTransaction,
type TransactionSummary,
} from "./storage/transaction-summary.ts";
export { convertCellsToLinks, isCell, isStream } from "./cell.ts";
export {
getCellOrThrow,
Expand Down
Loading