Skip to content

Implement translate tool for note.tsx #1994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 31, 2025
Merged

Implement translate tool for note.tsx #1994

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b7ca42c
Implement `translate` tool for `note.tsx`
bfollington Oct 31, 2025
4ca1356
Remove unused `ifElse`
bfollington Oct 31, 2025
71e04ce
Prefer `null` check
bfollington Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Prefer null check 
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
  • Loading branch information
@bfollington @cubic-dev-ai
bfollington and cubic-dev-ai[bot] authored Oct 31, 2025
commit 71e04ce1c4b1386d6eb4cee18675e1d745cda8fc
2 changes: 1 addition & 1 deletion packages/patterns/note.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ const Note = recipe<Input, Output>(

return derive(result, ({ pending, result }) => {
if (pending) return undefined;
if (!result) return "Error occured";
if (result == null) return "Error occured";
return result;
});
},
Expand Down