Skip to content

Conversation

@jsantell
Copy link
Collaborator

@jsantell jsantell commented Oct 31, 2025

Summary by cubic

Typed JSX style objects so the style prop supports a string or a typed object, and added types for the common-google-oauth element. Improves type safety and editor autocomplete for CSS and custom JSX elements.

  • Refactors

    • Added CSSStyleDeclaration and DOMCSSProperties types; style now accepts string | DOMCSSProperties.
    • Added types for "common-google-oauth" with $auth and scopes attributes.
    • Updated CTInputLegacyAttributes: value is CellLike.
  • Migration

    • Use valid CSSStyleDeclaration keys in style objects (camelCase; vendor prefixes allowed).
    • Values must be string or number; remove booleans/arrays.
    • For custom CSS properties (e.g., --foo), use a style string or cast to DOMCSSProperties.

Written for commit f456c7e. Summary will update automatically on new commits.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Copy link
Contributor

@seefeldb seefeldb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@jsantell jsantell merged commit 1ff7423 into main Oct 31, 2025
9 checks passed
@jsantell jsantell deleted the jsx-style-types-symlink branch October 31, 2025 18:44
jkomoros pushed a commit that referenced this pull request Nov 2, 2025
* chore: Type style objects in JSX

* Add types for common-google-oauth
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants