Fix/hierarchical params followups

[mathpirate]

Map closures – reuse shared helpers for computed aliases and restore stable derive inputs; update fixtures to reflect hierarchical params without runtime regressions.

---

Summary by cubic

Fixes hierarchical params and computed alias handling in map closures, and makes derive inputs stable by always passing object captures. Updates fixtures to match the consistent codegen and avoids runtime regressions.

• Bug Fixes

  • Handle computed property aliases in map callbacks by emitting key vars and derive-based alias reads, preserving reactivity.
  • Always call derive with an object of captures; remove the single-arg shortcut for stable inputs.
  • Correct map params shape (element, index, params) and binding normalization; support outer element access and keys.
  • Ensure test copying creates destination directories before file writes.

• Refactors

  • Add element binding analysis and computed alias collection; reuse capture access helper.
  • Improve identifier utilities to support astral Unicode characters and sanitize invalid fallbacks.
  • Centralize property/param name generation and binding/parameter helpers across transformers to deduplicate logic.
  • Extract a type traversal helper and use it for opaque-ref brand detection.

^{Written for commit 0a451ca. Summary will update automatically on new commits.}

[cubic-dev-ai]

1 issue found across 20 files

Prompt for AI agents (all 1 issues)

Understand the root cause of the following 1 issues and fix them.


<file name="packages/ts-transformers/src/closures/transformer.ts">

<violation number="1" location="packages/ts-transformers/src/closures/transformer.ts:632">
When computed aliases exist, the callback parameter now loses any other destructured bindings (e.g., `{ foo }`), so those locals disappear after transformation. Please keep the original bindings alongside the alias handling.</violation>
</file>

_{React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.}

[cubic-dev-ai]

When computed aliases exist, the callback parameter now loses any other destructured bindings (e.g., { foo }), so those locals disappear after transformation. Please keep the original bindings alongside the alias handling.

Prompt for AI agents

Address the following comment on packages/ts-transformers/src/closures/transformer.ts at line 632:

<comment>When computed aliases exist, the callback parameter now loses any other destructured bindings (e.g., `{ foo }`), so those locals disappear after transformation. Please keep the original bindings alongside the alias handling.</comment>

<file context>
@@ -461,6 +466,331 @@ function normalizeBindingName(
+  );
+
+  return {
+    bindingName: elementIdentifier,
+    elementIdentifier,
+    computedAliases: aliasBucket,
</file context>