Dx1/cleanup cell brand detection

[mathpirate]

Clean up various parts of the schema-generator and ts-transformers package in light of new CELL_BRAND mechanism

---

Summary by cubic

Centralized CELL_BRAND detection in @commontools/schema-generator/cell-brand and updated schema-generator and ts-transformers to use it. Wrapper detection now relies on brands for Cell/Stream/OpaqueRef, supports brand variants, and correctly handles unions (optional/nullable).

• New Features

  • Schema generation recognizes comparable, readonly, writeonly as Cell; stream and opaque as expected.
  • Added tests and fixtures for brand variants and opaque detection.

• Refactors

  • Moved brand logic to packages/schema-generator/src/typescript/cell-brand.ts and exported as @commontools/schema-generator/cell-brand.
  • Simplified CommonToolsFormatter and IntersectionFormatter to use the shared brand API.
  • Removed legacy, intersection-based OpaqueRef detection and duplicate brand code in ts-transformers.
  • Updated Deno imports to include @commontools/schema-generator/cell-brand.
  • Enforced CELL_BRAND for wrapper detection in schema-generator; updated test prelude and fixtures.

^{Written for commit 6a66c46. Summary will update automatically on new commits.}

[cubic-dev-ai]

1 issue found across 14 files

Prompt for AI agents (all 1 issues)

Understand the root cause of the following 1 issues and fix them.


<file name="packages/utils/src/typescript/cell-brand.ts">

<violation number="1" location="packages/utils/src/typescript/cell-brand.ts:51">
extractWrapperTypeReference never inspects union types, so a branded wrapper like `Cell&lt;T&gt; | undefined` falls through and returns `undefined`, even though getCellBrand already found the CELL_BRAND. Optional or nullable cells are therefore treated as non-cells, breaking schema/transformer logic that relies on wrapper info.</violation>
</file>

_{React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.}

[cubic-dev-ai]

extractWrapperTypeReference never inspects union types, so a branded wrapper like Cell<T> | undefined falls through and returns undefined, even though getCellBrand already found the CELL_BRAND. Optional or nullable cells are therefore treated as non-cells, breaking schema/transformer logic that relies on wrapper info.

Prompt for AI agents

Address the following comment on packages/utils/src/typescript/cell-brand.ts at line 51:

<comment>extractWrapperTypeReference never inspects union types, so a branded wrapper like `Cell&lt;T&gt; | undefined` falls through and returns `undefined`, even though getCellBrand already found the CELL_BRAND. Optional or nullable cells are therefore treated as non-cells, breaking schema/transformer logic that relies on wrapper info.</comment>

<file context>
@@ -0,0 +1,219 @@
+      return prop;
+    }
+  }
+  return undefined;
+}
+
</file context>

[cubic-dev-ai]

No issues found across 1 file