fix(api): Make OpaqueRef<Cell<T>> unwrap to Cell<T> #2017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed OpaqueRef type to properly unwrap BrandedCell types instead of wrapping them recursively. This prevents OpaqueRef<Cell<T>> from becoming OpaqueRef<OpaqueRef<T>>. Also updated IKeyableOpaque.key() return type to use OpaqueCell instead of OpaqueRef for consistency, and added necessary type casts throughout the codebase where OpaqueCell methods (connect, set, setSchema, export) are called on OpaqueRef values. This allows passing `Cell` as recipe inputs and using them as such in code that closes over them (future PRs will add actual closure support for them).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed OpaqueRef type to properly unwrap BrandedCell types instead of wrapping them recursively. This prevents OpaqueRef<Cell> from becoming OpaqueRef<OpaqueRef>.
Also updated IKeyableOpaque.key() return type to use OpaqueCell instead of OpaqueRef for consistency, and added necessary type casts throughout the codebase where OpaqueCell methods (connect, set, setSchema, export) are called on OpaqueRef values.
This allows passing
Cellas recipe inputs and using them as such in code that closes over them (future PRs will add actual closure support for them).Summary by cubic
Fixes OpaqueRef so OpaqueRef<Cell> unwraps to Cell instead of nesting. Aligns key() to return OpaqueCell, enabling Cells to be passed as recipe inputs and used directly.
Written for commit 0db1d04. Summary will update automatically on new commits.