fix(ct-select): Use areLinksSame for object value equality #2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, ct-select used JavaScript's strict equality (===) to compare values when determining which option should be selected. This worked fine for primitives but failed for object values like Cells because it compared by reference. Now using areLinksSame() from @commontools/runner which properly compares Cell objects and other link-based values by their identity rather than reference. Changes: - Import areLinksSame from @commontools/runner - Replace values.includes() with values.some(v => areLinksSame(v, item.value)) for multiple select - Replace item.value === val with areLinksSame(item.value, val) for single select Fixes regression where charm objects and other Cell-based values weren't being properly selected in ct-select dropdowns.
e68bfaa to
2fa4f3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, ct-select used JavaScript's strict equality (===) to compare
values when determining which option should be selected. This worked fine
for primitives but failed for object values like Cells because it compared
by reference.
Now using areLinksSame() from @commontools/runner which properly compares
Cell objects and other link-based values by their identity rather than
reference.
Changes:
for multiple select
single select
Fixes regression where charm objects and other Cell-based values weren't
being properly selected in ct-select dropdowns.
Summary by cubic
Fix ct-select to compare values with areLinksSame from @commontools/runner, rather than strict equality. This restores correct selection for object values (Cells/charm objects) in both single and multiple selects.
Written for commit 2fa4f3b. Summary will update automatically on new commits.