Skip to content

Conversation

@cubic-dev-ai
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot commented Nov 5, 2025

🤖 PR by cubic

This PR addresses the comment in #2019 – feat(default-app): Simplify pattern list with clickable names and minimal actions

File: packages/patterns/default-app.tsx
Line: 186
Comment:

Use a real link (with an href) or a button here; the current without href is not keyboard accessible.

This fix was automatically generated. Please review the changes carefully before merging.


Summary by cubic

Replaced a non-accessible anchor with a proper link in default-app to support keyboard navigation, addressing the accessibility comment from #2019. Added href and preventDefault to preserve the existing visit() behavior.

  • Bug Fixes
    • Standardized link text to use the charm name with a fallback to "Untitled".

Written for commit 1c99fca. Summary will update automatically on new commits.

Tony Espinoza and others added 4 commits November 5, 2025 12:32
…imal actions

Improved the pattern list UI for better usability and cleaner appearance:

- Made pattern names clickable links with hover underline (removed Visit button)
- Replaced "Remove" button text with trash icon (🗑️)
- Changed trash button to ghost variant (transparent background)
- Added CSS styling for pattern name hover effects
- Increased spacing around action buttons for better visual balance

The result is a more intuitive interface where users can click pattern names
directly to visit them, and actions are represented with clear visual icons.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Copy link
Contributor Author

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@tonyespinoza1 tonyespinoza1 force-pushed the feat/simplify-pattern-list-actions branch from 0915c70 to f2a4a6b Compare November 5, 2025 21:54
Base automatically changed from feat/simplify-pattern-list-actions to main November 5, 2025 22:08
@cubic-dev-ai cubic-dev-ai bot closed this Nov 5, 2025
@cubic-dev-ai
Copy link
Contributor Author

cubic-dev-ai bot commented Nov 5, 2025

This fix PR has been automatically closed because the parent PR #2019 was closed.

If you still need this fix, please reopen the parent PR first, or create a new PR with these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants