Resurrect compileAndRun example and integrate omnibot
#2025
+46
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue was that navigateTo was being called immediately with the result from compileAndRun, but the result Cell is initially undefined and only gets populated asynchronously after compilation completes. Solution follows the same pattern used in chatbot-list-view.tsx: - Use a lift to monitor the result Cell reactively - Only navigate once the result is populated (not undefined) - Use an isNavigated flag to ensure navigation only happens once Changes: - Add navigateWhenReady lift that waits for result to be ready - Update visit handler to use the lift instead of calling navigateTo directly - Show actual error messages in the UI instead of generic "fix the errors" This fixes the "blackhole" issue where navigateTo appeared to do nothing.
The previous approach called compileAndRun inside the handler, which: - Created a NEW compileAndRun action on every handler invocation - Caused double invocation due to re-renders from pending state changes - Hit the run index check at compile-and-run.ts:191 and bailed early Solution: - Call compileAndRun once in the recipe body (already done for error display) - Reuse the stable result cell from that single compileAndRun call - Handler just calls navigateTo(result) on the existing cell - navigateTo is an Action, so it re-runs when result populates This is much simpler and avoids the double invocation issue entirely. No need for the navigateWhenReady lift workaround!
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="packages/runner/src/builtins/compile-and-run.ts">
<violation number="1" location="packages/runner/src/builtins/compile-and-run.ts:179">
When the recipe is cancelled, this guard sees the aborted signal and returns before clearing the pending cell, so the compile action stays stuck in pending=true even though it has stopped. Please allow pending to be reset after cancellation.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
| if (thisRun !== currentRun) return; | ||
| // Only process this error if the request hasn't been superseded | ||
| if (requestId !== thisRequestId) return; | ||
| if (abortController?.signal.aborted) return; |
There was a problem hiding this comment.
When the recipe is cancelled, this guard sees the aborted signal and returns before clearing the pending cell, so the compile action stays stuck in pending=true even though it has stopped. Please allow pending to be reset after cancellation.
Prompt for AI agents
Address the following comment on packages/runner/src/builtins/compile-and-run.ts at line 179:
<comment>When the recipe is cancelled, this guard sees the aborted signal and returns before clearing the pending cell, so the compile action stays stuck in pending=true even though it has stopped. Please allow pending to be reset after cancellation.</comment>
<file context>
@@ -156,10 +168,15 @@ export function compileAndRun(
- if (thisRun !== currentRun) return;
+ // Only process this error if the request hasn't been superseded
+ if (requestId !== thisRequestId) return;
+ if (abortController?.signal.aborted) return;
runtime.editWithRetry((asyncTx) => {
</file context>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
llm.tscompiler.tsxto patterns packageSummary by cubic
Restored the compileAndRun example and fixed navigation by waiting for the compiled result. Adds cancellation and request dedupe so stale compilations don’t update state.
Bug Fixes
Refactors
Written for commit 679e741. Summary will update automatically on new commits.