common-frp #21
Merged
common-frp #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Convert to class style - Four types: stream, readonly stream, cell, computedcell
The functioanl style of definition is definitely terser and more fluent. Being able to destructure and restructure cells means we can offer readonly without a special type.
- Allows for glitch-free reactivity. - Does not allow for cycles - To allow cycles, we'll need to complete the implementation in experimental
- Two transaction phases, updates and reads - Updates sets state, marks computed dirty, reads recalculates computed (using call stack as an implicit topological sorting mechanism) TODO: write tests
We want streams to run before cell state updates so that they can only sample the state of the graph before it updates. ...also fix bug with scan where it was one step behind.
- Streams are feed-forward (no loops) - Cells allow loops through push-pull - Streams are buffered - Cells are last write wins - Streams prevent the diamond problem by zipping pairwise (events are held up until both sides have provided a value... if one stream goes faster, then it builds up in a buffer)
We probably don't want to expose these to library consumers in some cases? Removing them as methods and exposing as functions gives us more optionality in what to expose to consumers. TODO: need to figure out a cleverer way of hiding subscription endpoint than a symbol.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.