Skip to content

Codemirror component #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 17, 2024
Merged

Codemirror component #215

merged 8 commits into from
Oct 17, 2024

Conversation

@gordonbrander
Copy link
Contributor

@gordonbrander gordonbrander commented Oct 16, 2024 •
edited
Loading

Available via <os-code-editor>

Fixes #189

Notes

Source code can be reset via source attribute.

Language highlighting is toggled via mime type on lang prop/attr. Supported languages:

  • css: "text/css"
  • html: "text/html"
  • javascript: "text/javascript"
  • jsx: "text/x.jsx"
  • typescript: "text/x.typescript"
  • json: "application/json"
  • markdown: "text/markdown"

Example

<os-code-editor lang="text/javascript" source="console.log('hello world');">
</os-code-editor>
<os-code-editor lang="text/x.typescript" source="function hello(text: string) {}">
</os-code-editor>
<os-code-editor lang="text/css" source=".foo { font-weight: bold; }">
</os-code-editor>

@gordonbrander gordonbrander mentioned this pull request Oct 16, 2024
Closed
@gordonbrander
Add theme
2d4785d
@gordonbrander
Remove deprecated codemirror dep
3fca126
@gordonbrander
Fix CodeMirror dep with npm dedupe
8e7bc35 
See https://discuss.codemirror.net/t/release-0-20-0/4302/5

There was an error breaking syntax highlighting:

```
CodeMirror plugin crashed: TypeError: tags3 is not iterable
```

Caused by mismatched dependency versions. This can occur if using
CodeMirror 5 and CodeMirror 6 in the same repo.

npm dedupe resolved the issue.
@gordonbrander
Remove top padding from container
d976ef8
@gordonbrander
Expose destroy on editors
45d5d2b 
- Expose destroy method on editors
- Rename cleanup to cancel, in keeping with nomenclature elsewhere
- Remove focus border from editor
@gordonbrander
Allow configuration of source code and language
f823c84
@gordonbrander
Expose editor state get/set
b35a0ad
@gordonbrander gordonbrander marked this pull request as ready for review October 17, 2024 16:40
@gordonbrander gordonbrander merged commit 275a8a7 into main Oct 17, 2024
@gordonbrander gordonbrander deleted the feat/2024-10-16-codemirror-componet branch October 17, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Codemirror component

2 participants

@gordonbrander