Skip to content

Add safearea styling to sidebar group #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Add safearea styling to sidebar group #231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions typescript/packages/common-os-ui/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,11 @@
<os-charm-row icon="cloud" text="Weather"> </os-charm-row>
<os-charm-row icon="folder" text="CHEM131"> </os-charm-row>
</os-charm-row-group>
<os-sidebar-group>
<os-sidebar-group safearea>
<div slot="label">Notes</div>
<os-rich-text-editor></os-rich-text-editor>
</os-sidebar-group>
<os-sidebar-group>
<os-sidebar-group safearea>
<div slot="label">Title</div>
<p>
Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do
Expand Down
12 changes: 11 additions & 1 deletion typescript/packages/common-os-ui/src/components/os-sidebar-group.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,23 @@ export class OsSidebarGroup extends LitElement {
.sgroup {
gap: var(--u);
}

.sgroup-heading {
padding-left: var(--pad);
padding-right: var(--pad);
}

:host([safearea]) .sgroup-content {
padding-left: var(--pad);
padding-right: var(--pad);
}
`,
];

override render() {
return html`
<aside class="sgroup vstack">
<heading class="sgroup-heading pad-h"
<heading class="sgroup-heading"
><slot class="label" name="label"></slot
></heading>
<div class="sgroup-content"><slot></slot></div>
Expand Down