Skip to content

Conversation

@seefeldb
Copy link
Contributor

@seefeldb seefeldb commented Jan 8, 2025

First step of refactoring: Teaching RendererCell about schemas, etc. (this will eventually become the cell).

@seefeldb seefeldb requested a review from anotherjesse January 8, 2025 20:22
@anotherjesse
Copy link
Contributor

There doesn't appear to be any breakage - except for tests

main...refactor-cells-merge is my fix of the merge conflict

it breaks two tests - where it expects "item" instead of "element" in the alias for x:

 ❯ test/recipe.test.ts:226:7
    224|     expect(
    225|       (multiplyArray.nodes[0].inputs as { op: Recipe }).op.nodes[0].inputs,
    226|     ).toEqual({
       |       ^
    227|       x: { $alias: { cell: 1, path: ["argument", "item", "x"] } },
    228|       factor: { $alias: { path: ["argument", "factor"] } },

@seefeldb seefeldb merged commit d67a299 into main Jan 10, 2025
@seefeldb seefeldb deleted the refactor-cells branch January 10, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants