React exploration & Common-Charm extraction #302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add works, but I don't think it opens it fully... (eg, I don't think it is running at this point)
moving to common-charm for now allows llhl and jumble to share logic
|
@seefeldb thoughts on the extraction of charm stuff to common-charm? (I'm guessing recipe stuff / more of the charm stuff can go there too) the idea is that llhl / our chrome shouldn't have the logic around running/starting/.. recipes/charms - just to use it |
0e56740 to
ff89481
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a start of react for the chrome/shell, which includes starting moving the charm logic from lookslike-high-level to common-charm