Painful integrations #379
Merged
Painful integrations #379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…subscriptions
Previously, integrate() would throw an error ("Subscription is cancelled")
if an update arrived after the subscription had been cancelled. This happened
due to a race condition where in-flight updates were still delivered even
after the subscription was removed from active subscriber lists.
Now, integrate() checks if the subscription’s controller is missing and
logs a warning while ignoring the update, rather than throwing an error.
This ensures that cancelled subscriptions do not cause fatal errors while
preventing memory leaks by properly unwatching and clearing subscriber channels.
fixes #378
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where in-flight updates were still being delivered to a subscription even after it had been cancelled. This race condition caused the
integrate()function to be called on a subscription whose controller had already been cleared, resulting in a fatal error.To fix this, the
integrate()function now checks if the subscription’s controller exists. If not, it logs a warning and simply ignores the update rather than throwing an error. Additionally, the subscription’scancel()function ensures that all channels are unwatched and the subscriber is removed from active lists, preventing any future updates.fixes #378