Potential fix for issue #380 #384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@bfollington if this works for you feel free to merge! |
Contributor
|
Looks like the right fix to me, it's always dangerous storing reference types within |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm running out of steam, but was hoping to get this fixed before I left for the day. After working through this with o3-mini, I think this might be a reasonable fix.
In the breaking commit, the removal of the
useEffect(and the associated state/references) inCharmManagerContext.tsxmeant that a new instance of theCharmManagerwas being created on every render rather than only when theeffectiveReplicachanged.By wrapping the creation of the
CharmManagerin auseMemothat depends oneffectiveReplica, the code ensures that the same instance is used across renders unless the effective replica actually changes.