Skip to content

Mobile compatibility pass #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 26, 2025
Merged

Mobile compatibility pass #460

merged 5 commits into from
Feb 26, 2025

Conversation

@bfollington
Copy link
Contributor

@bfollington bfollington commented Feb 26, 2025 •
edited by jakedahn
Loading

  • Ripped apart CharmDetailView and split into components
  • Cleaned up mobile iteration experience
  • Move edit button to action stack
  • Move actions out of toolbar and into global abstraction
Screen.Recording.2025-02-26.at.5.26.03.pm_captioned.mp4

TODO

  • Fix variant thumbnail rendering
image

@bfollington bfollington marked this pull request as ready for review February 26, 2025 07:32
@bfollington bfollington requested a review from jakedahn February 26, 2025 07:34
jakedahn
jakedahn approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@jakedahn jakedahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a huge improvement, thank you for making it happen!

I fixed up the variant thumbnail sizing, and made the variants checkbox true by default because it's now awesome :D

@jakedahn jakedahn merged commit 8a780f7 into main Feb 26, 2025
4 checks passed
@jakedahn jakedahn deleted the feat/2025-02-26-mobile-ui-pass branch February 26, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakedahn jakedahn jakedahn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bfollington @jakedahn