Skip to content

set input event cells to be ephemeral #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2025
Merged

set input event cells to be ephemeral #463

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
set input event cells to be ephemeral 
otherwise as they are frozen/readOnly, it breaks sync
  • Loading branch information
@anotherjesse
anotherjesse committed Feb 26, 2025
commit 4be053224380d55f2675b74ce00f65db3f55c6ec
2 changes: 2 additions & 0 deletions typescript/packages/common-runner/src/runner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,6 +346,7 @@ function instantiateJavaScriptNode(
}

const inputsCell = getDoc(eventInputs, cause);
inputsCell.ephemeral = true;
inputsCell.freeze(); // Freezes the bindings, not aliased cells.

const frame = pushFrameFromCause(cause, {
Expand Down Expand Up @@ -374,6 +375,7 @@ function instantiateJavaScriptNode(
// Schedule the action to run when the inputs change

const inputsCell = getDoc(inputs);
inputsCell.ephemeral = true;
inputsCell.freeze(); // Freezes the bindings, not aliased cells.

let resultCell: DocImpl<any> | undefined;
Expand Down
Loading