Skip to content

fix storage tests #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2025
Merged

fix storage tests #471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion typescript/packages/common-charm/src/storage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,12 @@ class StorageImpl implements Storage {
let provider = this.storageProviders.get(space);

if (!provider) {
const type = (import.meta as any).env?.VITE_STORAGE_TYPE ?? "remote";
// Default to "remote", but let either custom URL (used in tests) or
// environment variable override this.
const type =
this.remoteStorageUrl?.protocol === "memory:"
? "memory"
: ((import.meta as any).env?.VITE_STORAGE_TYPE ?? "remote");

if (type === "remote") {
if (!this.remoteStorageUrl) throw new Error("No remote storage URL set");
Expand Down
Loading
Loading