Make common-ui component properties lenient
#49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Postel's Law: be conservative in what you do, be liberal in what you accept from others. Properties were previously being validated and would complain if you included a property that was not allowed. Instead, we want to validate properties, while allowing additional properties, but ignoring those additional properties when rendering. This will make us more robust to LLM hallucinations.
- We make the validator more lenient - Also the validator decorates the object in various ways that we don't want to expose, so better to give it its own copy
common-ui component properties lenient
gordonbrander
approved these changes
Jun 17, 2024
seefeldb
pushed a commit
that referenced
this pull request
Jun 17, 2024
* Make vnode properties liberal in what they accept Postel's Law: be conservative in what you do, be liberal in what you accept from others. Properties were previously being validated and would complain if you included a property that was not allowed. Instead, we want to validate properties, while allowing additional properties, but ignoring those additional properties when rendering. This will make us more robust to LLM hallucinations. * Give JSON validator a different object - We make the validator more lenient - Also the validator decorates the object in various ways that we don't want to expose, so better to give it its own copy --------- Co-authored-by: Gordon Brander <gordonbrander@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the user to supply extraneous properties, we will just ignore them.