Skip to content

fix: linter warnings, including removing deprecated parse #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2025
Merged

fix: linter warnings, including removing deprecated parse #511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee340f6
fix linter warnings, including removing deprecated parse
seefeldb Mar 4, 2025
6620f61
also type case to (so far unenforced) did shape for spaces
seefeldb Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions typescript/packages/common-cli/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// Load .env file
import { parse } from "https://deno.land/std@0.224.0/flags/mod.ts";
import { parseArgs } from "https://deno.land/std@0.224.0/cli/parse_args.ts";
import {
CharmManager,
compileRecipe,
Expand All @@ -9,7 +9,10 @@ import {
import { getEntityId, isStream } from "@commontools/runner";
import { Identity } from "@commontools/identity";

let { space, charmId, recipeFile, cause } = parse(Deno.args);
const { space, charmId, recipeFile, cause } = parseArgs(Deno.args, {
string: ["space", "charmId", "recipeFile", "cause"],
default: {},
});

const toolshedUrl = Deno.env.get("TOOLSHED_API_URL") ??
"https://toolshed.saga-castor.ts.net/";
Expand All @@ -18,10 +21,10 @@ storage.setRemoteStorage(new URL(toolshedUrl));
setBobbyServerUrl(toolshedUrl);

async function main() {
console.log("params:", { space, charmId, recipeFile, cause });
const identity = await Identity.fromPassphrase("common-cli");
console.log("params:", { space, identity, charmId, recipeFile, cause });
const manager = await CharmManager.open({
space: space ?? identity.did(),
space: (space as `did:key:${string}`) ?? identity.did(),
signer: identity,
});
const charms = await manager.getCharms();
Expand Down
1 change: 0 additions & 1 deletion typescript/packages/common-cli/recipes/simpleValue.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
// @ts-nocheck
import { h } from "@commontools/html";
import {
cell,
Expand Down
3 changes: 1 addition & 2 deletions typescript/packages/deno.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading