Skip to content

Fix: Updating values in normalized-to-docs arrays #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2025
Merged

Fix: Updating values in normalized-to-docs arrays #515

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions typescript/packages/common-runner/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import {
} from "./query-result-proxy.ts";
import { isCell } from "./cell.ts";
import { type ReactivityLog } from "./scheduler.ts";
import { createRef } from "./doc-map.ts";
import { createRef, getDocByEntityId } from "./doc-map.ts";

export function extractDefaultValues(schema: any): any {
if (typeof schema !== "object" || schema === null) return undefined;
Expand Down Expand Up @@ -556,10 +556,20 @@ export function normalizeToDocLinks(
// transition from a previous run, but only if the value didn't
// change as well.
} else {
value[i] = { cell: getDoc(value[i]), path: [] } satisfies DocLink;
value[i].cell.entityId = itemId;
value[i].cell.space = parentDoc.space;
value[i].cell.sourceCell = parentDoc;
const previousDoc = getDocByEntityId(parentDoc.space!, itemId, false);
if (previousDoc) {
// TODO(seefeld): We should instead accumulate the changes and send
// them back as a whole. Do that together with no longer changing
// data inline?
previousDoc.send(value[i]);
value[i] = previousDoc;
} else {
value[i] = { cell: getDoc(value[i]), path: [] } satisfies DocLink;
// Have to do it manually, since we're not specifying the cause, but the entityId directly.
value[i].cell.entityId = itemId;
value[i].cell.space = parentDoc.space;
value[i].cell.sourceCell = parentDoc;
}

preceedingItemId = itemId;
log?.writes.push(value[i]);
Expand Down