chore: Enable 'no-external-import' lint #520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
633adb4 to
3165bd6
Compare
3165bd6 to
a6056b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the no-external-import lint flag. This prevents us from writing inline dependencies via URL or
jsr/npmdirectives, and instead relies on importing indeno.json.Generally, if a dependency is used by more than one package, I put it in the workspace deno.json, otherwise, only in the package deno.json.
A big goal here is to easily inspect dependencies (e.g. all in a
deno.json) and avoid importing version X in one package and version Y in another (unless we need to, of course)