Add more input components #54
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
seefeldb
commented
Jun 18, 2024
- added ability to set constant props in view()
- added checkbox and textInput that use that
- added checkbox and textInput that use that
gordonbrander
suggested changes
Jun 18, 2024
| import { view } from "../hyperscript/render.js"; | ||
| import { eventProps } from "../hyperscript/schema-helpers.js"; | ||
|
|
||
| export const checkbox = view( |
There was a problem hiding this comment.
Would express this as:
export const input = view(
"input",
{
...eventProps(),
type: { type: { anyOf: ["text", "checkbox"] } }
id: { type: "string" },
checked: { type: "boolean" },
value: { type: "string" },
}
);
Input is a weird edge case because the properties are disjoint from the tag type, and the type property acts as a flag that customizes the input properties. We don't currently have a way to express tags that are disjoint from their properties like that.
There was a problem hiding this comment.
Ah, I see you do this in input.ts. Suggest deleting this file.
| checked: { type: "boolean" }, | ||
| value: { type: "string" }, | ||
| }, | ||
| { type: "checkbox" } |
There was a problem hiding this comment.
See note on third argument below.
| value: { type: "string" }, | ||
| placeholder: { type: "string" }, | ||
| }, | ||
| { type: "text" } |
There was a problem hiding this comment.
Rather than adding a third argument to vnode/render, if we want specialized factories, I would suggest something like:
export const textInput = (props: Props) => input({...props, type: 'text'})| export const view = ( | ||
| tagName: string, | ||
| props: JSONSchemaRecord = {}, | ||
| constantProps: Props = {} |
There was a problem hiding this comment.
See note on third argument above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.