setup signer for storage in toolshed #541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
561dc1c to
d2f60bc
Compare
d2f60bc to
876dcc3
Compare
jakedahn
requested changes
Mar 6, 2025
| : docLink; | ||
|
|
||
| if (!signer) { | ||
| signer = await Identity.fromPassphrase("toolshed"); |
There was a problem hiding this comment.
Minor request:
Could you make this env.TOOLSHED_SIGNER_PASSPHRASE, and add a new entry with default value of "toolshed" to env.ts? https://github.com/commontoolsinc/labs/blob/main/typescript/packages/toolshed/env.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.