Skip to content

feat: Handle unhandled errors in worker thread by not crashing parent thread #937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2025
Merged

feat: Handle unhandled errors in worker thread by not crashing parent thread #937

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions background-charm-service/src/service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ import { SpaceManager } from "./space-manager.ts";
import { useCancelGroup } from "@commontools/runner";

export interface BackgroundCharmServiceOptions {
identity: Identity,
toolshedUrl: string,
identity: Identity;
toolshedUrl: string;
}

export class BackgroundCharmService {
Expand Down
14 changes: 8 additions & 6 deletions background-charm-service/src/worker-controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,9 @@ export class WorkerController {
// FIXME(ja): what should we do if the worker is erroring?
// perhaps restart the worker?
this.worker.onerror = (err) => {
log(`${this.did}: Worker error:`, err, {
error: true,
});
log(`${this.did}: Worker error:`, { error: true }, err);
// If not prevented, error is rethrown in this context.
err.preventDefault();
};
}

Expand All @@ -87,9 +87,11 @@ export class WorkerController {
toolshedUrl,
rawIdentity: identity.serialize(),
}).catch((err) => {
log(`Worker controller ${this.did} worker setup failed:`, err, {
error: true,
});
log(
`Worker controller ${this.did} worker setup failed:`,
{ error: true },
err,
);
}).then(() => {
this.ready = true;
log(`Worker controller ${this.did} ready for work`);
Expand Down