Skip to content

Conversation

@seefeldb
Copy link
Contributor

@seefeldb seefeldb commented Mar 31, 2025

See #924 for why this is useful

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to enhance error reporting in the storage component by ensuring any storage error (including conflicts) is logged.

  • Added a branch to log errors using both a custom log function and console.error.
Comments suppressed due to low confidence (1)

runner/src/storage.ts:772

  • [nitpick] The error is logged twice (once via a custom log function and again with console.error). Consider consolidating these logging calls if they provide the same information to reduce redundancy.
log(() => ["storage error", result.error]);

@seefeldb seefeldb merged commit 135a84e into main Mar 31, 2025
6 checks passed
@seefeldb seefeldb deleted the log-storage-errors branch March 31, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants