Log metadata in worker errors #943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances error logging in worker errors by introducing a type guard function to verify additional error metadata.
- Adds isErrorWithContext to check for error properties.
- Updates exports in runner/src/index.ts to include the new function and error types.
- Modifies worker.ts to log extended details when error context is present.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| runner/src/scheduler.ts | Added isErrorWithContext function for error metadata validation. |
| runner/src/index.ts | Export updated to include isErrorWithContext and extended types. |
| background-charm-service/src/worker.ts | Updated error logging to output extended error details if available. |
| recipeId: string; | ||
| }; | ||
|
|
||
| export function isErrorWithContext(error: unknown): error is ErrorWithContext { |
There was a problem hiding this comment.
The type 'ErrorWithContext' only defines 'recipeId', yet the function checks for additional properties ('action', 'charmId', 'space'). Consider updating the ErrorWithContext type to include these properties or modifying the guard to align with the existing type definition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.