Fix/edit/rework planning and workflow classification CT-59 CT-104 #953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added new workflow classification system with three core workflows: - FIX: Address bugs without changing spec or schema - EDIT: Update functionality while preserving core schema - REWORK: Create new functionality with potentially new schema Implemented: - Intent classification using LLM - Plan generation based on workflow type - Preview integration in SpecPreview component - Workflow toggle UI in preview panel - Basic test coverage 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Fix imports in charm/src/imagine.ts - Fix CharmDetailView to use correct components - Update the SpecPreview component to use basic preview without workflow controls for now - Add proper fallbacks for LLM failures in tests 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add current implementation status section - Document integration with existing functionality - Add implementation details for each component - Outline next steps for further development 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
When a user mentions any charm (except the implicit reference to the current charm), we must use the "rework" workflow which: 1. Constructs an argument cell that can access data from all referenced charms 2. Builds a combined schema from all references 3. Uses castNewRecipe instead of iterate This change: - Updates classifyIntent to automatically classify as "rework" when references exist - Adds a check in generateWorkflowPreview to override user workflow selection - Updates IMAGINE-DESIGN.md with detailed explanation of the reference handling - Adds skeleton tests for the reference handling behavior 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
6a35590 to
50b8ec3
Compare
Next up: bug squashing
bfollington
commented
Apr 7, 2025
Comment on lines
+90
to
+92
|
|
||
| // XML tag functions have been moved elsewhere | ||
| // Tests will be updated when we create proper tests for the workflow module |
| For IMAGINE workflows you MUST include both <result_schema> tags with valid JSON schemas. | ||
| Each schema must be a JSON object with "type": "object" and must include a "properties" object with property definitions. | ||
| Example schema format: |
Contributor
Author
There was a problem hiding this comment.
We'll move the schema to the second step in a later PR
| } | ||
|
|
||
| // For rework workflows, extract both argument and result schemas | ||
| if (workflowType === "imagine") { |
Contributor
Author
There was a problem hiding this comment.
kinda messy logic, needs a cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo
currentcharmformworkflow.tsContext