schema fixes / status messages on failures #954
Conversation
|
@jsantell would love your review ... |
| bg.update({ | ||
| disabledAt: Date.now(), | ||
| lastRun: Date.now(), | ||
| status: error ? error : "Disabled", |
There was a problem hiding this comment.
consider: error ?? "Disabled"
There was a problem hiding this comment.
deno typescript doesn't like it:
Property 'error' does not exist on type '{ success: boolean; data?: any; charmId: string; } | { success: boolean; error: string; charmId: string; } | { success: boolean; error: string; }'.
Property 'error' does not exist on type '{ success: boolean; data?: any; charmId: string; }'.
deno-ts(2339)
There was a problem hiding this comment.
error is a string | undefined, not sure what that type is
There was a problem hiding this comment.
I think it might just be typescript being overly cautious?
| } | ||
|
|
||
| export async function newGetFunc(): Promise<Cell<Cell<BGCharmEntry>[]>> { | ||
| export async function getBGUpdaterCharmsCell(): Promise< |
| status: { type: "string" }, | ||
| disabledAt: { type: "number", default: 0 }, | ||
| lastRun: { type: "number", default: 0 }, | ||
| status: { type: "string", default: "" }, |
There was a problem hiding this comment.
Maybe worthwhile leaving a comment that this schema should (must?) match CharmEntrySchema in @commontools/utils/updaters
Probably a broader question, how does the worker code (via @commontools/utils/updaters) enforce/reject/ignore/handle data on read with a different written schema (e.g. BGCharmEntrySchema here)?
There was a problem hiding this comment.
good call - added the note
w.r.t. the broader question - as long as the schemas are additive the new defaults are loaded.
but I think we have to be careful - as I don't think anything stops us from breaking things with schema changes that aren't backwards compatible
Uh oh!
There was an error while loading. Please reload this page.