feat: expose since field in query / subscription results #969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ubik2
reviewed
Apr 2, 2025
| ChangesBuilder.set(differential, [of], the, { | ||
| [cause]: { | ||
| is, | ||
| since: since - 1, |
There was a problem hiding this comment.
You're setting since lower so your subsequent merge of changes works?
There was a problem hiding this comment.
since supposed to signify which commit introduced the change, so it seems reasonable to suggest that commit itself was introduced by a previous one. Perhaps that is twisted and it should be the same since ?
ubik2
approved these changes
Apr 2, 2025
|
This is a dead PR now, right @Gozala? |
|
Got merged as a part of #989 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.