Skip to content

[Feature] Adding a trailing icon on filter text (topic name) and removing existing bracket and text #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sj-jain opened this issue Mar 26, 2023 · 5 comments · Fixed by #316
Assignees
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 🏁 status: ready for work Ready for work

Comments

@sj-jain
Copy link

sj-jain commented Mar 26, 2023

Problem

Currently used bracket and text [X] as a trailing icon for removing filter choice is confusing seems like part of the text itself with no functionality .

Description

Adding a trailing icon according to vocabulary design language that improves the functionality and user experience for removing a tag or filter . This will also help upcoming fellow contributors to understand the functionality of the filters.

##Screenshots
image 7
image 6
image 8 (3)

Implementation

Replace [x] to trailing cross icon svg from vocabulary docs

@possumbilities @TimidRobot

@sj-jain sj-jain added ✨ goal: improvement Improvement to an existing feature 💻 aspect: code Concerns the software code in the repository 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🟩 priority: low Low priority and doesn't need to be rushed labels Mar 26, 2023
@tripathics
Copy link

Is this issue still open? I'm interested on solving this

@sj-jain
Copy link
Author

sj-jain commented Mar 29, 2023

@tripathics glad to know that you're interested in solving this issue , its open but still it is not approved by maintainers hence not ready for work , for more info kindly look this https://opensource.creativecommons.org/contributing-code/repo-labels/

@possumbilities
Copy link
Contributor

@sj-jain agree I'm leaning both ways on the comma. It might be better to instead of adding the comma to increase the spacing between all the links a bit give them more visual room?

As for redoing the closing indicator the brackets are not perfect, but I'm not sure removing them makes it necessarily better.

Moving to a discussion so others can chime in on their thoughts.

@possumbilities possumbilities added 💬 talk: discussion Open for discussions and feedback and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Mar 31, 2023
@cc-open-source-bot cc-open-source-bot added 🏷 status: label work required Needs proper labelling before it can be worked on and removed 🏷 status: label work required Needs proper labelling before it can be worked on labels Apr 1, 2023
@cc-open-source-bot cc-open-source-bot added 🏷 status: label work required Needs proper labelling before it can be worked on and removed 🏷 status: label work required Needs proper labelling before it can be worked on labels Apr 9, 2023
@cc-open-source-bot cc-open-source-bot added 🏷 status: label work required Needs proper labelling before it can be worked on and removed 🏷 status: label work required Needs proper labelling before it can be worked on labels Apr 16, 2023
@cc-open-source-bot cc-open-source-bot added 🏷 status: label work required Needs proper labelling before it can be worked on and removed 🏷 status: label work required Needs proper labelling before it can be worked on labels Mar 18, 2024
@cc-open-source-bot cc-open-source-bot added 🏷 status: label work required Needs proper labelling before it can be worked on and removed 🏷 status: label work required Needs proper labelling before it can be worked on labels Mar 25, 2024
@cc-open-source-bot cc-open-source-bot added 🏷 status: label work required Needs proper labelling before it can be worked on and removed 🏷 status: label work required Needs proper labelling before it can be worked on labels Apr 1, 2024
@Murdock9803 Murdock9803 added 🏁 status: ready for work Ready for work and removed 💬 talk: discussion Open for discussions and feedback 🏷 status: label work required Needs proper labelling before it can be worked on labels Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 🏁 status: ready for work Ready for work
Projects
None yet
7 participants