-
-
Notifications
You must be signed in to change notification settings - Fork 136
Improves UI for the category filters and makes the page responsive #316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@possumbilities Please have a look at the Pull Request 🙌 |
docs/index.html
Outdated
| <!-- This is the resourcenavbar, which contains the category filters. The categories are TOPIC, MEDIUM and LANGUAGE. This is for the homepage, so all the filters are being displayed for the user to choose from. --> | ||
| <aside id="resourcenavbar"> | ||
| <!-- The link to display all the resources. The homepage contains the top 16 resources by default. --> | ||
| <h3 id="see-all"><a href="/all">See All Resources</a></h3> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be an h3, and should appear below the thumbnail listing; since it would act as a "see more" link to load more items in the listing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated the code, and made this to be an <a> tag, located below Thumbnaillist.
|
@Murdock9803 After seeing this in action I believe a better route of UX improvement would be not including the filters at all on the However, once we dive down into the |
|
@possumbilities This makes perfect sense 🙌
|
possumbilities
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks and works great! Approved.
Fixes
Description
The Pull Request mainly aims at improving the user interface for the category filters situated at the
index.htmland theall.htmlpages. The PR makes them as a sidebar, also works on the responsiveness of the whole pages.The PR solves many issues as most of them are co-related.
Technical details
The pull request:
index.htmlandall.htmlindex.htmllisting.htmlsee-all-resourceslinkcheckboxin place of[x]in category filters.media-querybreakpointsindex.html,all.htmlandstyle.cssfiles.Screenshots
The new look is like following in different widths:



Checklist
Update index.md).mainormaster).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin