-
-
Notifications
You must be signed in to change notification settings - Fork 136
Adds footer.html file to the _includes directory #280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
docs/_includes/footer.html
Outdated
</svg> | ||
</div> | ||
</footer> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing end of file here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This happened as a result of poor formatting, now the end of file is present
docs/_includes/footer.html
Outdated
</li> | ||
<li> | ||
<a href="https://mail.creativecommons.org/subscribe" target="_blank" | ||
>Newsletter</a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the result of the formatting here the use of prettier?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I didn't format the file with prettier, and as a result it was not indented properly. Now the file is formatted using prettier. Please suggest any changes required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wonderful! Approved.
@possumbilities, is there anything left to do, to get this PR merged ? |
Fixes
Description
The pull request adds a separate file
footer.html
to the_includes
directory to ensure easy reusability of the footer component across different pages.Checklist
Update index.md
).main
ormaster
).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin