Skip to content

refactored the html and css for resource page #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Jul 8, 2024

Conversation

Murdock9803
Copy link
Member

Fixes

Description

The pull request aims at improving the user interface for resource.html page by making the HTML and CSS semantic and aligned with the vocabulary.

Technical details

The pull request performs the following tasks:

  • Refactors the whole code for resource.html page by implementing semantic HTML.
  • Improves the styling of the page in styles.css, by utilizing vocabulary.
  • makes the page responsive (enhanced the width property), just like the Vocabulary Blog Post Page

Screenshots

The final output for the page looks like this:
image

image

image

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Murdock9803 Murdock9803 requested a review from a team as a code owner July 8, 2024 15:38
@Murdock9803 Murdock9803 requested review from TimidRobot, annatuma and possumbilities and removed request for a team, TimidRobot and annatuma July 8, 2024 15:38
@Murdock9803
Copy link
Member Author

@possumbilities I have improved the UI for the resource page. Please have a look at the PR.
For now, i have kept the page heading similar to what is implemented in the vocabulary blog post. Please suggest any variations for the heading and whole code changes 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants