Skip to content

Code organisation can be improved #60

Closed
@dhruvkb

Description

@dhruvkb

Description

Currently the code in the repository is organised in directories on the basis of the GitHub Actions workflow they enable, each with its own Python environment and each independent of the other. This however does not take into account that multiple workflows may share code, utility functions and constants with each other.

For example in #58, a number of constants and functions were duplicated from push_data_to_ccos/ to sync_community_team/ because the way the repos are organised prohibits sharing. I believe the code can be better organised to be more DRY, all the while maintaining a reasonable amount of separation between the different workflows.

Reproduction

  1. Write a new workflow
  2. Observe inability to reuse existing code
  3. Feel dread as you copy code, verbatim, from one folder to another.

Expectation

Even when concerns are separated, constants and common functions like setting up a client to GitHub or Asana should be placed in a central location and shared.

Resolution

  • I would be interested in resolving this bug.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions