Skip to content

fail gracefully when a user does not exist (ex. GitHub user rename) #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions sync_community_team/set_teams_on_github.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
}


def create_teams_for_data(databag):
def create_teams_for_data(databag, exit_status):
client = set_up_github_client()
organization = get_cc_organization(client)

Expand Down Expand Up @@ -41,14 +41,15 @@ def create_teams_for_data(databag):

print(f" Populating members for team {team.name}...")
members = [member["github"] for member in members]
map_team_to_members(client, team, members, True)
exit_status = map_team_to_members(client, team, members, exit_status, True)
print(" Done.")
print(" Done.")
print("Done.")
return exit_status


def map_team_to_members(
client, team, final_user_logins, non_destructive=False
client, team, final_user_logins, exit_status, non_destructive=False
):
"""
Map the team to the given set of members. Any members that are not already
Expand Down Expand Up @@ -78,13 +79,15 @@ def map_team_to_members(
user = client.get_user(login)
except UnknownObjectException:
print(f" ERROR: User not found: {login}")
raise
exit_status = 1
continue
team.add_membership(user)

current_login = client.get_user().login
if current_login not in final_user_logins:
current_user = client.get_user(current_login)
team.remove_membership(current_user)
return exit_status


def map_team_to_repos(
Expand Down
4 changes: 3 additions & 1 deletion sync_community_team/sync_teams.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,10 @@ def __init__(self, message, code=None):


def main():
create_teams_for_data(get_community_team_data())
exit_status = 0
exit_status = create_teams_for_data(get_community_team_data(), exit_status)
create_codeowners_for_data(get_community_team_data())
sys.exit(exit_status)


if __name__ == "__main__":
Expand Down