Skip to content

Implement Exclusion of Exempt Users #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 15, 2024
Merged

Implement Exclusion of Exempt Users #224

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
286593f
update the function update_branch_protection
Oct 7, 2024
859918c
update branch protection by making relevant changes
Oct 8, 2024
6326cb2
update the branch_protections.yml file by adding a top-level EXEMPT_U…
Oct 9, 2024
f2bb29c
document and update/correct branch protections configuration
TimidRobot Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update branch protection by making relevant changes
  • Loading branch information
Silvia-Wachira committed Oct 8, 2024
commit 859918c9d14cad2e5f80189ffc9c48d851169f6d
4 changes: 2 additions & 2 deletions ccos/norm/branch_protections.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ EXEMPT_REPOSITORIES:
# exempted for bot pushes to default branch
- quantifying:
exempt_users:
-bot1
-bot2
# - bot1
# - bot2
# special purpose repo
- sre-wiki-js
# special purpose repo
Expand Down
2 changes: 1 addition & 1 deletion normalize_repos.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ def update_branch_protection(repo):
exempt_repositories = config["EXEMPT_REPOSITORIES"]
required_status_check_map = config["REQUIRED_STATUS_CHECK_MAP"]

exempt_users = config.get["exempt_users, {}).get(repo.name, [])"]
exempt_users = config.get("EXEMP_USERS", {}).get(repo.name, [])

if repo.name not in exempt_repositories and is_engineering_project(repo):
LOG.info(f"{repo.name}: updating branch protections")
Expand Down